Skip to content

Cisco umbrella playbook changes and repackage#11603

Merged
v-dvedak merged 109 commits intomasterfrom
cisco_umbrella_playbook
Jan 20, 2025
Merged

Cisco umbrella playbook changes and repackage#11603
v-dvedak merged 109 commits intomasterfrom
cisco_umbrella_playbook

Conversation

@v-amolpatil
Copy link
Copy Markdown
Contributor

@v-amolpatil v-amolpatil commented Dec 26, 2024

Required items, please complete

Change(s):

  • Playbook version changes for below 3 playbooks. Re-structrucing of folders, update readme for all playbooks with images.

    1. AddIpToDestinationList
    2. AssignPolicyToIdentity
    3. GetDomainInfo
    4. There is no change in BlockDomain playbook and its custom connector as the API is not deprecated for Enforcement.

Reason for Change(s):

  • V1 version is deprecated and upgraded to newer version v2 and updated readme links and its code. Repackaged solution as well.
  • This new version has lot of changes in legacy urls so we updated this as well.

Version Updated:

  • NA

Testing Completed:

  • Yes

Checked that the validations are passing and have addressed any issues that are present:

  • Yes

Alekhya0824 and others added 30 commits May 7, 2024 10:40
@v-amolpatil v-amolpatil marked this pull request as ready for review December 26, 2024 10:53
@v-amolpatil v-amolpatil requested review from a team as code owners December 26, 2024 10:53
Copy link
Copy Markdown
Collaborator

@rahul0216 rahul0216 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes mostly looks good. There are few spelling mistakes in readme files. Please correct those.

rahul0216
rahul0216 previously approved these changes Dec 30, 2024
Copy link
Copy Markdown
Collaborator

@rahul0216 rahul0216 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes. Approved.

Copy link
Copy Markdown
Contributor

@manishkumar1991 manishkumar1991 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@Azure Azure deleted a comment from contentautomationbot bot Jan 20, 2025
@Azure Azure deleted a comment from contentautomationbot bot Jan 20, 2025
@v-dvedak v-dvedak merged commit b2f891b into master Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Content-Package Playbook Playbook specialty review needed Solution Solution specialty review needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants